endpointstate: Add an interface to wait for endpoint restore #29243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
This was referenced Nov 17, 2023
|
@pippolo84 can you add a codeowner for endpointstate please? |
f854d91 to
8008794
Compare
Done. I've assigned |
qmonnet
approved these changes
Nov 21, 2023
Provide an API to let callers wait for the endpoint restoration to be completed. To avoid import cycles, the interface wrapping the API is defined outside of the daemon/cmd package where it is implemented. This allows cells to require an endpointstate.Restorer through Hive dependency injection without pulling in the daemon/cmd package. This is a required step to migrate the k8s CEP watchers to Resource[T]. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
8008794 to
818a7be
Compare
Thanks for the pointers, I've fixed the commit message. 👍 |
|
/test |
lmb
approved these changes
Nov 22, 2023
This was referenced Nov 24, 2023
jrajahalme
approved these changes
Nov 30, 2023
Yep, it'll be used in the modularized endpoint GC: #29246 |
aanm
approved these changes
Dec 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an API to let callers wait for the endpoint restoration to be completed. To avoid import cycles, the interface wrapping the API is defined outside of the
daemon/cmdpackage where it is implemented. This allows cells to require anendpointstate.Restorerthrough Hive dependency injection without pulling in thedaemon/cmdpackage.This is a required step to migrate the k8s CEP watchers to Resource[T]. Refer to this comment for more information.
Related: #28159