Skip to content

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Nov 13, 2023

With this PR, the L7 Loadbalancing controller gets migrated to use the controller-runtime library.

This improves the reconciliation by reconciling on changes at the owned CiliumEnvoyConfig (e.g. re-creating it after it has been deleted, ...)

This commit introduces and registers the skeleton for the
l7 loadbalancing reconciler based on the controller-runtime
library.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Nov 13, 2023
@mhofstetter
Copy link
Member Author

/test

With this commit, the L7 Loadbalancing based on Envoy gets migrated
from the pure informer to a controller-runtime library based implementation.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/l7lb-controller-runtime branch from 7ec4c8a to 739740e Compare November 13, 2023 12:35
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review November 13, 2023 12:46
@mhofstetter mhofstetter requested a review from a team as a code owner November 13, 2023 12:46
@mhofstetter mhofstetter requested a review from meyskens November 13, 2023 12:46
@mhofstetter mhofstetter changed the title L7 Loadbalancing: Use controller-runtime library L7 Loadbalancing: Migrate to controller-runtime library Nov 13, 2023
This commit removes the package global log.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/l7lb-controller-runtime branch from 739740e to 5447790 Compare November 14, 2023 10:22
Copy link
Contributor

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is a related issue to this code with multiple ports on one service but this will only make it easier to debug :) (not related to this)

@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter reopened this Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 14, 2023
@julianwiedmann julianwiedmann merged commit 68a95b4 into cilium:main Nov 14, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/l7lb-controller-runtime branch November 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/servicemesh GH issues or PRs regarding servicemesh kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants