Skip to content

bgpv1: fix incorrect error messages in the reconcilePodIPPool function #29125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

bgpv1: fix incorrect error messages in the reconcilePodIPPool function #29125

merged 1 commit into from
Nov 13, 2023

Conversation

hargrovee
Copy link

The function of 'reconcilePodIPPool' is to advertise or withdraw CIDR routes for the podippool, not for service routes. The log information is incorrect.

bgpv1: fix incorrect error messages in the reconcilePodIPPool function
60ee152 
The function of 'reconcilePodIPPool' is to advertise or withdraw CIDR
routes for the podippool, not for service routes. The log information
is incorrect.

Signed-off-by: Huagong Wang <wanghuagong@kylinos.cn>
@hargrovee hargrovee requested a review from a team as a code owner November 13, 2023 09:22
@hargrovee hargrovee requested a review from rastislavs November 13, 2023 09:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 13, 2023
@rastislavs rastislavs added the release-note/misc This PR makes changes that have no direct user impact. label Nov 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2023
@rastislavs rastislavs added area/bgp Impacts the Border Gateway Protocol feature. kind/cleanup This includes no functional changes. labels Nov 13, 2023
rastislavs
rastislavs approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rastislavs
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@squeed squeed merged commit 03a37e0 into cilium:main Nov 13, 2023
@hargrovee hargrovee deleted the fix-incorrect-error-messages-in-the-reconcilePodIPPool-function branch November 14, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hargrovee @rastislavs @squeed