Skip to content

Conversation

sayboras
Copy link
Member

Currently, the only child resource that is related to infra is the load balancer Service. This commit is to make sure that user-specified labels and annotations in Gateway are propagated accordingly. Kindly note that there is no validation right now.

Currently, the only child resource that is related to infra is the load
balancer Service. This commit is to make sure that user-specified labels
and annotations in Gateway are propagated accordingly. Kindly note that
there is no validation right now.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2023
@sayboras sayboras added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api labels Nov 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 13, 2023
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review November 13, 2023 07:48
@sayboras sayboras requested a review from a team as a code owner November 13, 2023 07:48
@sayboras sayboras requested a review from meyskens November 13, 2023 07:48
Copy link
Contributor

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@julianwiedmann julianwiedmann merged commit 64da993 into cilium:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants