gateway-api: Add supported features in GatewayClass status #29116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tam Mach <tam.mach@cilium.io>
|
/test |
meyskens
reviewed
Nov 13, 2023
|
Can you add a PR description :) changes look good but probably needs some context to merge it |
|
Just for reference in the GEP, this relates to kubernetes-sigs/gateway-api#2162 |
You are correct. I was waiting for the upstream conformance test to run tests depending on the feature sets in the gateway status. However, there are still some gaps upstream, so this is manually updated right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new status.supportedFeature introduced in Gateway resource, the goal is to make things visible to users about capabilities of implementation. This commit is to add all the supported features into cilium-managed Gateway.
Kindly note that the list is hard coded right now, as there is no enum/const defined in upstream main codebase (only available in conformance tests).