Skip to content

Conversation

Zariel
Copy link
Contributor

@Zariel Zariel commented Nov 10, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

The config maps fail to render if either dashboard or operator annotations are specified, this is due to the operator annotations not being accessed using $.Values.operator.annotations and fixes the following error.

Error: template: cilium/templates/cilium-operator/dashboards-configmap.yaml:23:20: executing "cilium/templates/cilium-operator/dashboards-configmap.yaml" at <.Values.operator.annotations>: can't evaluate field Values in type []uint8

Fix rendering helm operator-dashboard annotations

The config maps fail to render if either dashboard or operator annotations are specified, this is due to the operator annotations not being accessed using $.Values.operator.annotations and fixes the following error.

`Error: template: cilium/templates/cilium-operator/dashboards-configmap.yaml:23:20: executing "cilium/templates/cilium-operator/dashboards-configmap.yaml" at <.Values.operator.annotations>: can't evaluate field Values in type []uint8`

Signed-off-by: Chris Bannister <c.bannister@gmail.com>
@Zariel Zariel requested review from a team as code owners November 10, 2023 13:44
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 10, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 10, 2023
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes locally, everything looks good.

Thank you for the contribution @Zariel

@tommyp1ckles
Copy link
Contributor

/test

@tommyp1ckles tommyp1ckles added release-note/bug This PR fixes an issue in a previous release of Cilium. area/helm Impacts helm charts and user deployment experience labels Nov 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2023
@tommyp1ckles
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@gandro gandro merged commit 8d26e38 into cilium:main Nov 13, 2023
@Zariel Zariel deleted the patch-1 branch November 13, 2023 10:25
@Zariel
Copy link
Contributor Author

Zariel commented Nov 13, 2023

Thank you team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants