ingress: migrate secret-sync to controller-runtime #29198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
meyskens
reviewed
Nov 20, 2023
09a6236 to
3155530
Compare
|
I addressed the input from @meyskens . Thanks a lot! |
sayboras
approved these changes
Nov 21, 2023
3155530 to
ea42dca
Compare
This commit adds the possibility to define additional watches in addition to watching the object that is referencing the TLS Secret directly. This provides the possibility to trigger reconciliation based on other events. E.g. Default IngressClass changes Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit introduces the possibility to define the default Secret. Default Secrets aren't referenced explicitly. Therefore, this Secrets are referenced regardless of whether they are referenced or not. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit migrates the secret-sync for Ingress related TLS secrets to use the controller-runtime based secret syncer, that is already used by Ciliums Gateway API implementation. By reusing the same secret-syncer we avoid potential problems of fighting two syncers with each other. Especially if Gateway API & Ingress can potentially have two different secret namespaces! Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit removes the old, now unused, implementation of the Ingress Secret Sync based on informers. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
ea42dca to
c19a148
Compare
|
rebased to |
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the "Cilium Ingress to controller-runtime library" migration (#28911), this PR migrates the TLS secret synchronization logic. This gets achieved by re-using functionality of the new secret-synchronization cell that is already using the controller-runtime library and is used by the Gateway API controller too (follow up of #29100).
For more information, please refer to the individual commits.
IngressClass)