Set correct cluster name and id during upgrade test #29165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cilium#29108 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
|
/test |
aanm
approved these changes
Nov 16, 2023
|
I will mark it as ready-to-merge as both Maciej and Nicolas are out of office and this change only affects tests (also got two approvals) |
|
I've hit this on stable branches, any reason we couldn't backport this? |
|
@bimmlerd I don't mind backporting. It was a long time ago, but I am assuming I haven't seen this error on other stable branches at that time 🤔 |
|
@marseel I guess there's not really a backporting criteria for CI fixes, but as a release manager I'd definitely enjoy seeing CI fixes trickle down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29108
more details in issue.