Skip to content

Conversation

bimmlerd
Copy link
Member

@bimmlerd bimmlerd commented Nov 14, 2023

If previous devices and new devices are equal, we don't wait for the invalidation of the query, and run into a busy loop until the devices change.

Fixes: 03ad61b (datapath/linux: Implement DevicesController) @joamaki - I've mentioned the bug to Jussi (who's on PTO atm), he agrees it's a bug, hence not pulling him in for review.

AFAIK this was never in a release thus not marking this a release-note/bug, but happy to be corrected on that.

If previous devices and new devices are equal, we don't wait for the
invalidation of the query, and run into a busy loop until the devices
change.

Fixes: 03ad61b (datapath/linux: Implement DevicesController)

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
@bimmlerd bimmlerd added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. release-note/misc This PR makes changes that have no direct user impact. area/agent Cilium agent related. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Nov 14, 2023
@bimmlerd bimmlerd marked this pull request as ready for review November 14, 2023 10:48
@bimmlerd bimmlerd requested a review from a team as a code owner November 14, 2023 10:48
@bimmlerd
Copy link
Member Author

/test

@bimmlerd
Copy link
Member Author

Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 14, 2023
@julianwiedmann julianwiedmann merged commit fc8f9ec into cilium:main Nov 14, 2023
@bimmlerd bimmlerd deleted the pr/bimmlerd/fix-busy-loop-in-device-manager branch November 15, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Cilium agent related. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants