Skip to content

bpf: nat: limit EgressGW redirect check to bpf_host #29159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

bpf: nat: limit EgressGW redirect check to bpf_host #29159

merged 1 commit into from
Nov 14, 2023

Conversation

julianwiedmann
Copy link
Member

The relevant EgressGW code in snat_v4_needs_masquerade() is already constrained to IS_BPF_HOST. Make the redirect check consistent.

@julianwiedmann
bpf: nat: limit EgressGW redirect check to bpf_host
27b4768 
The relevant EgressGW code in snat_v4_needs_masquerade() is already
constrained to IS_BPF_HOST. Make the redirect check consistent.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. feature/egress-gateway Impacts the egress IP gateway feature. labels Nov 14, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann requested a review from jibi November 14, 2023 11:39
@julianwiedmann julianwiedmann marked this pull request as ready for review November 14, 2023 11:39
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 14, 2023 11:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 14, 2023
@julianwiedmann julianwiedmann merged commit d93506e into cilium:main Nov 14, 2023
@julianwiedmann julianwiedmann deleted the 1.15-bpf-snat-egressgw branch November 14, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianwiedmann @jibi