cilium-dbg, policy, api: Fix labels in policy selectors output #29152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous iteration, the labels type was an interface{} which we
would type assert to the labels.LabelArray type. Upon investigation,
this failed most of the time, but for some reason it had worked before,
as the fixed commit was eventually merged.
This commit fixes it permanently by specifying the type in the OpenAPI
spec so that a type assertion is no longer needed.
Fixes: 1e41011 ("api, cmd, policy: Show rule labels in `policy
selectors` output")
Reported-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Suggested-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
|
/test |
nebril
approved these changes
Nov 14, 2023
squeed
approved these changes
Nov 15, 2023
nathanjsweet
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous iteration, the labels type was an interface{} which we
would type assert to the labels.LabelArray type. Upon investigation,
this failed most of the time, but for some reason it had worked before,
as the fixed commit was eventually merged.
This commit fixes it permanently by specifying the type in the OpenAPI
spec so that a type assertion is no longer needed.
Fixes: 1e41011 ("api, cmd, policy: Show rule labels in
policy selectorsoutput")Reported-by: Tom Hadlaw tom.hadlaw@isovalent.com
Suggested-by: Tom Hadlaw tom.hadlaw@isovalent.com
Signed-off-by: Chris Tarazi chris@isovalent.com