Skip to content

Bug: Fix module health status output #29140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Bug: Fix module health status output #29140

merged 1 commit into from
Nov 14, 2023

Conversation

derailed
Copy link
Contributor

@derailed derailed commented Nov 13, 2023 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Add fall safe to ensure module health tree rendering does not panic when producing the output.

Note: This was a reported failure during ci testing where the cilium
status command failed with panic: strings: negative Repeat count

Fixes: #issue-number

Signed-off-by: Fernand Galiana fernand.galiana@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 13, 2023
@derailed derailed force-pushed the pr/fix_modulehealth_output branch 2 times, most recently from ef946f2 to e188aff Compare November 13, 2023 19:55
@derailed derailed marked this pull request as ready for review November 13, 2023 20:12
@derailed derailed requested a review from a team as a code owner November 13, 2023 20:12
@derailed derailed requested a review from thorn3r November 13, 2023 20:12
thorn3r
thorn3r approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I think a rebase will correct your CI issues: 93f26fd

@derailed
Bug: Fix module health status output
3f2cae4 
Add fall safe to ensure module health tree rendering output does not
panic when producing the output.

Note: This was a reported failure during ci testing where the cilium
status command failed with `panic: strings: negative Repeat count`

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed derailed force-pushed the pr/fix_modulehealth_output branch from e188aff to 3f2cae4 Compare November 14, 2023 15:48
@gandro
Copy link
Member

gandro commented Nov 14, 2023

/test

@gandro gandro mentioned this pull request Nov 14, 2023
Closed
@gandro gandro added area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 14, 2023
@gandro gandro merged commit 01e9612 into cilium:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derailed @gandro @thorn3r