Skip to content

endpoint: Clarify policy locking requirements #29024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

endpoint: Clarify policy locking requirements #29024

merged 1 commit into from
Nov 22, 2023

Conversation

jrajahalme
Copy link
Member

Add commentary and rename 'LookupRedirectPortLocked' as 'LookupRedirectPortBuildLocked' to signify that the endpoint's build mutex must be held, while the endpoint mutex is not held during this call.

@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. labels Nov 7, 2023
@jrajahalme jrajahalme requested review from a team as code owners November 7, 2023 10:23
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 7, 2023
@jrajahalme
Copy link
Member Author

/test

@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label Nov 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 7, 2023
@jrajahalme
Copy link
Member Author

/test

@jrajahalme jrajahalme mentioned this pull request Nov 7, 2023
Merged
@jrajahalme jrajahalme force-pushed the policy-clarify-locking-requirements branch from f18e5d2 to bd24910 Compare November 9, 2023 01:58
@jrajahalme
Copy link
Member Author

rebased for CI fixes

@jrajahalme
Copy link
Member Author

/test

aditighag
aditighag previously requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. Feel free to mark the PR as ready for merge once you've fixed it.

@jrajahalme jrajahalme force-pushed the policy-clarify-locking-requirements branch from bd24910 to ab8c35c Compare November 17, 2023 13:01
@jrajahalme jrajahalme dismissed aditighag’s stale review November 17, 2023 13:02

No need to bother reviewer again for a godoc fix.

@jrajahalme jrajahalme requested a review from aditighag November 17, 2023 13:02
@jrajahalme
Copy link
Member Author

/test

aditighag
aditighag approved these changes Nov 21, 2023
View reviewed changes
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 21, 2023
@jrajahalme
endpoint: Clarify policy locking requirements
ede8710 
Add commentary and rename 'LookupRedirectPortLocked' as
'LookupRedirectPortBuildLocked' to signify that the endpoint's build
mutex must be held, while the endpoint mutex is not held during this
call.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the policy-clarify-locking-requirements branch from ab8c35c to ede8710 Compare November 22, 2023 05:13
@jrajahalme
Copy link
Member Author

/test

@lmb lmb removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 22, 2023
@lmb
Copy link
Contributor

lmb commented Nov 22, 2023

Tests are failing, bumped them.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 22, 2023
@lmb lmb merged commit 5dec515 into cilium:main Nov 22, 2023
@joamaki joamaki mentioned this pull request Jan 30, 2024
Merged
28 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jan 30, 2024
@aanm aanm added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrajahalme @lmb @nebril @aditighag @joamaki @aanm