service: fix service manager interface mismatch caused by merge race #29018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
approved these changes
Nov 7, 2023
|
/test |
Due to a merge race, the SyncWithK8sFinished method of the ServiceManager interface did not match the actual implementation. Let's fix it. Fixes: 66ba850 ("services: refactor SyncWithK8sFinished to return stale services") Fixes: cf4279c ("services: don't wait for clustermesh to delete local stale backends") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
2e4efbb to
cf7cc37
Compare
|
/test |
joamaki
approved these changes
Nov 7, 2023
|
Build (which was previously broken) is green again, let's merge to unblock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a merge race, the SyncWithK8sFinished method of the ServiceManager interface did not match the actual implementation. Let's fix it.
Fixes: 66ba850 ("services: refactor SyncWithK8sFinished to return stale services")
Fixes: cf4279c ("services: don't wait for clustermesh to delete local stale backends")