Skip to content

Conversation

nbusseneau
Copy link
Member

Cilium itself officially supports K8s 1.28 since
6a70af2, however platforms did not have a compatible 1.28 version available for managed clusters until recently.

Cilium itself officially supports K8s 1.28 since
6a70af2, however platforms did not have
a compatible 1.28 version available for managed clusters until recently.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Nov 6, 2023
@nbusseneau nbusseneau requested review from a team as code owners November 6, 2023 14:23
@nbusseneau nbusseneau requested a review from brlbil November 6, 2023 14:23
@nbusseneau
Copy link
Member Author

/ci-aks

@nbusseneau
Copy link
Member Author

/ci-eks

@nbusseneau
Copy link
Member Author

/ci-gke

@nbusseneau
Copy link
Member Author

/ci-awscni

@brlbil
Copy link
Contributor

brlbil commented Nov 7, 2023

It seems AKS still does not support 1.28

@nbusseneau
Copy link
Member Author

It seems AKS still does not support 1.28

Correct, I got misled by my local environment yesterday, it's still not GA.

@nbusseneau
Copy link
Member Author

1.28 is now GA on AKS and test passed: https://github.com/cilium/cilium/actions/runs/6772112977

We can mark ready to merge as soon as reviews are in :)

Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 23, 2023
@lmb lmb enabled auto-merge November 24, 2023 10:34
@lmb lmb disabled auto-merge November 24, 2023 10:34
@lmb lmb enabled auto-merge November 24, 2023 10:34
@lmb
Copy link
Contributor

lmb commented Nov 24, 2023

Please run the full suite in the future so that this can go into the merge queue automatically.

@lmb
Copy link
Contributor

lmb commented Nov 24, 2023

/test

@nbusseneau
Copy link
Member Author

@lmb This PR does not need to run the full test suite, it only modifies a restricted set of files, and does not need to go through the merge queue. My bad for not properly mentioning it when saying it was ready to merge.

@aanm aanm disabled auto-merge November 27, 2023 11:18
@aanm aanm merged commit c8ed487 into main Nov 27, 2023
@aanm aanm deleted the pr/update-k8s-compatibility branch November 27, 2023 11:18
mhofstetter added a commit to mhofstetter/cilium that referenced this pull request Nov 28, 2023
Currently, the tests `ci-eks` & `ci-aws-cni` fail due to issues deploying
multiple clusters with the same name in the same region.

Therefore, this commit uses a different region for k8s version v1.24 to
ensure that only one cluster gets deployed per region.

Fixes: cilium#29004

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2023
Currently, the tests `ci-eks` & `ci-aws-cni` fail due to issues deploying
multiple clusters with the same name in the same region.

Therefore, this commit uses a different region for k8s version v1.24 to
ensure that only one cluster gets deployed per region.

Fixes: #29004

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
Currently, the tests `ci-eks` & `ci-aws-cni` fail due to issues deploying
multiple clusters with the same name in the same region.

Therefore, this commit uses a different region for k8s version v1.24 to
ensure that only one cluster gets deployed per region.

Fixes: cilium#29004

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants