Skip to content

cni: remove unused CILIUM_CNI_CONF variable from install script #29063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

cni: remove unused CILIUM_CNI_CONF variable from install script #29063

merged 1 commit into from
Nov 14, 2023

Conversation

wedaly
Copy link

@wedaly wedaly commented Nov 8, 2023 •
edited
Loading

The CNI install script used to install both the CNI conflist and the CNI binary, but now it just installs the binary, so the CILIUM_CNI_CONF variable can be removed.

cni: remove unused CILIUM_CNI_CONF variable from install script
d83863e 
The CNI install script used to install both the CNI conflist
and the CNI binary, but now it just installs the binary,
so the CILIUM_CNI_CONF variable can be removed.

Signed-off-by: Will Daly <widaly@microsoft.com>
@wedaly wedaly requested a review from a team as a code owner November 8, 2023 21:38
@wedaly wedaly requested a review from tommyp1ckles November 8, 2023 21:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 8, 2023
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Nov 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 9, 2023
@tklauser tklauser requested a review from squeed November 9, 2023 08:56
@tklauser
Copy link
Member

tklauser commented Nov 9, 2023

/test

tommyp1ckles
tommyp1ckles approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming @squeed signs off 😉

squeed
squeed approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tommyp1ckles
Copy link
Contributor

/test

@tklauser tklauser merged commit 9118468 into cilium:main Nov 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 14, 2023
@julianwiedmann julianwiedmann added the area/cni Impacts the Container Networking Interface between Cilium and the orchestrator. label Nov 14, 2023
@wedaly wedaly mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/cni Impacts the Container Networking Interface between Cilium and the orchestrator. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wedaly @tklauser @tommyp1ckles @squeed @julianwiedmann