Skip to content

Conversation

julianwiedmann
Copy link
Member

snat_v4_nat_handle_mapping() already calls get_cluster_snat_map_v4(). Avoid doing it a second time in the same code path.

@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. feature/snat Relates to SNAT or Masquerading of traffic labels Nov 8, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner November 8, 2023 11:00
@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-nat-map-lookup branch from 3169624 to c917a3c Compare November 8, 2023 11:11
snat_v4_nat_handle_mapping() already calls get_cluster_snat_map_v4().
Avoid doing it a second time in the same code path.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-nat-map-lookup branch from c917a3c to 71d2bb7 Compare November 8, 2023 11:18
@julianwiedmann
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 13, 2023
@julianwiedmann julianwiedmann merged commit adde8b2 into cilium:main Nov 13, 2023
@julianwiedmann julianwiedmann deleted the 1.15-bpf-nat-map-lookup branch November 13, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/snat Relates to SNAT or Masquerading of traffic kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants