labels: further optimize IPStringToLabel for single IP case #29040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Pass the IP as a string to maskedIPToLabel. When called from IPStringToLabel in case of a single IP we already have the IP string and can avoid the additional allocation caused by ip.String(). For the call in the prefix case and in computeCIDRLabels there is no effect, the netip.Addr.String() call is just moved out. name old time/op new time/op delta IPStringToLabel/0.0.0.0/0-8 69.6ns ± 1% 71.0ns ± 2% +1.91% (p=0.001 n=9+10) IPStringToLabel/192.0.2.3-8 70.9ns ± 0% 50.6ns ± 0% -28.65% (p=0.000 n=10+9) IPStringToLabel/192.0.2.3/32-8 77.7ns ± 1% 78.1ns ± 1% +0.50% (p=0.003 n=10+10) IPStringToLabel/192.0.2.3/24-8 77.5ns ± 0% 79.9ns ±12% +3.02% (p=0.000 n=10+9) IPStringToLabel/192.0.2.0/24-8 77.5ns ± 0% 78.1ns ± 0% +0.67% (p=0.000 n=10+9) IPStringToLabel/::/0-8 108ns ± 0% 109ns ± 0% ~ (p=0.137 n=10+10) IPStringToLabel/fdff::ff-8 136ns ± 0% 74ns ± 0% -45.61% (p=0.000 n=10+10) IPStringToLabel/f00d:42::ff/128-8 155ns ± 0% 155ns ± 0% -0.28% (p=0.000 n=10+9) IPStringToLabel/f00d:42::ff/96-8 145ns ± 1% 144ns ± 0% -0.56% (p=0.007 n=10+10) name old alloc/op new alloc/op delta IPStringToLabel/0.0.0.0/0-8 24.0B ± 0% 24.0B ± 0% ~ (all equal) IPStringToLabel/192.0.2.3-8 32.0B ± 0% 16.0B ± 0% -50.00% (p=0.000 n=10+10) IPStringToLabel/192.0.2.3/32-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) IPStringToLabel/192.0.2.3/24-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) IPStringToLabel/192.0.2.0/24-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) IPStringToLabel/::/0-8 16.0B ± 0% 16.0B ± 0% ~ (all equal) IPStringToLabel/fdff::ff-8 32.0B ± 0% 16.0B ± 0% -50.00% (p=0.000 n=10+10) IPStringToLabel/f00d:42::ff/128-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) IPStringToLabel/f00d:42::ff/96-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta IPStringToLabel/0.0.0.0/0-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) IPStringToLabel/192.0.2.3-8 2.00 ± 0% 1.00 ± 0% -50.00% (p=0.000 n=10+10) IPStringToLabel/192.0.2.3/32-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) IPStringToLabel/192.0.2.3/24-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) IPStringToLabel/192.0.2.0/24-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) IPStringToLabel/::/0-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) IPStringToLabel/fdff::ff-8 3.00 ± 0% 2.00 ± 0% -33.33% (p=0.000 n=10+10) IPStringToLabel/f00d:42::ff/128-8 3.00 ± 0% 3.00 ± 0% ~ (all equal) IPStringToLabel/f00d:42::ff/96-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) Signed-off-by: Tobias Klauser <tobias@cilium.io>
b26c125 to
e4fab78
Compare
|
/test |
nathanjsweet
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the IP as a string to
maskedIPToLabel. When called fromIPStringToLabelin case of a single IP we already have the IP string and can avoid the additional allocation caused byip.String(). For the call in the prefix case and incomputeCIDRLabelsthere is no effect, thenetip.Addr.String()call is just moved out.