Skip to content

bpf: Add TC_ACT_REDIRECT check for nodeport #28927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

bpf: Add TC_ACT_REDIRECT check for nodeport #28927

merged 1 commit into from
Nov 6, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 1, 2023

@maintainer-s-little-helper
Copy link

Commit eb2c1ce does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 1, 2023
@sayboras sayboras force-pushed the tam/nodeport-bpf-overlay branch from eb2c1ce to 0fbe0e0 Compare November 1, 2023 12:22
@maintainer-s-little-helper
Copy link

Commit eb2c1ce does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.12 feature/k8s-gateway-api area/servicemesh GH issues or PRs regarding servicemesh and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. feature/k8s-gateway-api labels Nov 1, 2023
@sayboras sayboras force-pushed the tam/nodeport-bpf-overlay branch from 0fbe0e0 to d9518e0 Compare November 4, 2023 00:56
@sayboras sayboras force-pushed the tam/nodeport-bpf-overlay branch from d9518e0 to 3fc61dd Compare November 4, 2023 00:59
@sayboras
Copy link
Member Author

sayboras commented Nov 4, 2023

/test

@sayboras sayboras marked this pull request as ready for review November 6, 2023 11:07
@sayboras sayboras requested a review from a team as a code owner November 6, 2023 11:07
@sayboras sayboras requested a review from gentoo-root November 6, 2023 11:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2023
@sayboras sayboras merged commit 80d99a6 into cilium:main Nov 6, 2023
@sayboras sayboras deleted the tam/nodeport-bpf-overlay branch November 6, 2023 21:26
@jibi jibi mentioned this pull request Nov 7, 2023
Merged
15 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 7, 2023
@jibi jibi mentioned this pull request Nov 7, 2023
Merged
7 tasks
@jibi jibi mentioned this pull request Nov 7, 2023
Merged
6 tasks
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.13 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 8, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
This was referenced Nov 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
cilium v1.13.9
Status: Released
cilium v1.14.4
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayboras @gentoo-root @jibi