Skip to content

gha: Migrate from MetalLB to L2LB #28926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

gha: Migrate from MetalLB to L2LB #28926

merged 1 commit into from
Dec 13, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 1, 2023

This is to leverage Cilium L2LB in Gateway API tests.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2023
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Nov 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2023
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from e41a186 to 1091f36 Compare November 1, 2023 10:53
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from 1091f36 to 9383e19 Compare November 1, 2023 11:28
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch 2 times, most recently from a50f76b to bcfc658 Compare November 29, 2023 12:25
@sayboras
Copy link
Member Author

/ci-gatewayapi

@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from bcfc658 to 0877928 Compare December 12, 2023 10:11
@nvibert
Copy link
Contributor

nvibert commented Dec 12, 2023

Looks great @sayboras !

@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from 0877928 to 1b2fc82 Compare December 12, 2023 10:45
@sayboras sayboras changed the title gha: Migrate from MetalLB to L2LB gateway-api: Migrate from MetalLB to L2LB Dec 12, 2023
@sayboras sayboras changed the title gateway-api: Migrate from MetalLB to L2LB gha: Migrate from MetalLB to L2LB Dec 12, 2023
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from 1b2fc82 to 1b1a4bb Compare December 12, 2023 11:00
@sayboras
Copy link
Member Author

/test

@sayboras
gha: Migrate from MetalLB to L2LB
46fbd2a 
It would be great to test L2LB feature in the same workflow as well.
This commit is to enable L2LB for Ingress and Gateway API conformance
tests.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/replace-metabllb-with-cilium branch from 1b1a4bb to 46fbd2a Compare December 12, 2023 11:09
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review December 12, 2023 11:10
@sayboras sayboras requested review from a team as code owners December 12, 2023 11:10
viktor-kurchenko
viktor-kurchenko approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 13, 2023
@sayboras sayboras added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 86d60d2 Dec 13, 2023
@sayboras sayboras deleted the tam/replace-metabllb-with-cilium branch December 13, 2023 06:41
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
@sayboras sayboras mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
feature/k8s-gateway-api feature/k8s-ingress ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayboras @nvibert @viktor-kurchenko