Skip to content

Docs: Updates BGP CP Developer Docs #28908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

Docs: Updates BGP CP Developer Docs #28908

merged 1 commit into from
Nov 7, 2023
+3 −3

Conversation

danehans
Copy link
Contributor

Removes the deprecated tunnel Helm value in favor of routingMode in relevant files.

Fixes: #28907

@danehans
Updates BGP CP Developer Docs
73fad77 
Removes the deprecated `tunnel` Helm value in favor of the `routingMode`
value in relevant files.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans requested a review from a team as a code owner October 31, 2023 18:12
@danehans danehans requested a review from aditighag October 31, 2023 18:12
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 31, 2023
@danehans
Copy link
Contributor Author

danehans commented Nov 2, 2023

/test

aditighag
aditighag approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aditighag
Copy link
Member

@danehans The PR is missing release-note labels. Please see - https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#submitting-a-pull-request.

@danehans danehans added the release-note/misc This PR makes changes that have no direct user impact. label Nov 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 2, 2023
@danehans
Copy link
Contributor Author

danehans commented Nov 2, 2023

@aditighag thanks for the feedback. I added the release-note/misc since this PR fixes a doc that has yet to be included in a release.

@danehans
Copy link
Contributor Author

danehans commented Nov 3, 2023

/test

@danehans
Copy link
Contributor Author

danehans commented Nov 6, 2023

/ci-clustermesh

@danehans
Copy link
Contributor Author

danehans commented Nov 6, 2023

/ci-e2e

@danehans
Copy link
Contributor Author

danehans commented Nov 6, 2023

/ci-ipsec-e2e

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2023
@squeed squeed merged commit 4343ab0 into cilium:main Nov 7, 2023
@squeed
Copy link
Contributor

squeed commented Nov 7, 2023

@danehans in the future, you can ask for the ready-to-merge label be manually added for docs PRs, since they don't need the full CI.

@danehans danehans deleted the issue_28907 branch March 8, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: BGP CP Dev Docs Use Deprecated Helm Values
4 participants
@danehans @aditighag @squeed @YutaroHayakawa