Skip to content

build: Declare GO in makefile before first use #28983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

build: Declare GO in makefile before first use #28983

merged 1 commit into from
Nov 10, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 4, 2023

This is to avoid the below warning as $(GO) is not defined before calling GOARCH= $(GO) env GOARCH.

$ make
env: ‘GOARCH’: No such file or directory
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
...

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2023
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Nov 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2023
@sayboras sayboras added area/build Anything to do with the build, more general than area/CI dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 4, 2023
@sayboras sayboras marked this pull request as ready for review November 4, 2023 00:54
@sayboras sayboras requested a review from a team as a code owner November 4, 2023 00:54
@sayboras sayboras requested a review from brb November 4, 2023 00:54
@sayboras
Copy link
Member Author

sayboras commented Nov 6, 2023

/test

@sayboras
build: Declare GO in makefile before first use
0f43a7e 
This is to avoid the below warning as $(GO) is not defined before
calling GOARCH= $(GO) env GOARCH.

```bash
$ make
env: ‘GOARCH’: No such file or directory
contrib/scripts/check-logging-subsys-field.sh
contrib/scripts/check-fmt.sh
...
```

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

sayboras commented Nov 9, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 10, 2023
@squeed squeed merged commit a8aa022 into cilium:main Nov 10, 2023
@sayboras sayboras deleted the tam/makefile-go branch November 10, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general than area/CI ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayboras @brb @squeed