Skip to content

[v1.14] Author Backport of 28382 (Metrics associated with a deleted node should not be reported) #28980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

[v1.14] Author Backport of 28382 (Metrics associated with a deleted node should not be reported) #28980

merged 1 commit into from
Nov 8, 2023

Conversation

derailed
Copy link
Contributor

@derailed derailed commented Nov 3, 2023

Once this PR is merged, you can update the PR labels via:

$ for pr in 28382; do contrib/backporting/set-labels.py $pr done 1.14; done

@derailed derailed requested a review from a team as a code owner November 3, 2023 19:51
@derailed derailed added kind/backports This PR provides functionality previously merged into master. backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Nov 3, 2023
@derailed
Copy link
Contributor Author

derailed commented Nov 3, 2023

/test-backport-1.14

@derailed derailed force-pushed the pr/v1.14-backport-2023-11-03 branch from 5812b00 to 94e3914 Compare November 6, 2023 16:49
@christarazi
Copy link
Member

/test-backport-1.14

@tommyp1ckles
Copy link
Contributor

tommyp1ckles commented Nov 6, 2023 •
edited
Loading

Conformance e2e failure looks like: #27762

@derailed
Ensures prometheus metrics associated with a deleted node are no long…
4c04114 
…er reported.

[ upstream commit e9f97cd ]

When a node is deleted from a cluster, metrics associated with that node
are still being exported to prometheus. Short of restarting the agent,
we want to dynamically delete these metrics when a node is removed from the cluster.

This PR ensures node_connectivity_status and node_connectivity_latency
no longer report metrics for nodes that are no longer present on the
cluster.

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed derailed force-pushed the pr/v1.14-backport-2023-11-03 branch from 94e3914 to 4c04114 Compare November 7, 2023 14:32
@derailed
Copy link
Contributor Author

derailed commented Nov 7, 2023

/test-backport-1.14

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 8, 2023
@squeed squeed merged commit c659ded into cilium:v1.14 Nov 8, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
No open projects
cilium v1.14.4
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derailed @christarazi @tommyp1ckles @squeed