Skip to content

Change Hubble dashboard name #28971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Change Hubble dashboard name #28971

merged 1 commit into from
Nov 6, 2023

Conversation

saintdle
Copy link
Contributor

@saintdle saintdle commented Nov 3, 2023

Fixes issue where Hubble dashboard is not installed when hubble.dashboards.enabled=true helm value is used.

This is because the grafana sidecar cannot install the dashboard

logger=provisioning.dashboard type=file name=sidecarProvider t=2023-11-03T13:54:15.812999204Z level=error msg="failed to save dashboard" file=/tmp/dashboards/Hubble/hubble-dashboard.json error="Dashboard name cannot be the same as folder"

Fixes: #28970

Renamed Hubble Dashboard so that it can be installed by Grafana Sidecar.

@saintdle saintdle requested review from a team as code owners November 3, 2023 13:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 3, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 3, 2023
@kaworu kaworu requested review from chancez and a user and removed request for chancez November 3, 2023 14:17
ghost
ghost approved these changes Nov 3, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍

@christarazi christarazi added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. release-note/misc This PR makes changes that have no direct user impact. labels Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 3, 2023
@saintdle @christarazi
Change Hubble dashboard name
caf7acf 
Update hubble dashboard name

Signed-off-by: Dean <22192242+saintdle@users.noreply.github.com>
@christarazi
Copy link
Member

/test

@ghost ghost added the sig/hubble label Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2023
@aditighag aditighag merged commit 46bea90 into cilium:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@christarazi christarazi christarazi approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hubble dashboard not installed into grafana
4 participants
@saintdle @christarazi @nebril @aditighag