Skip to content

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 3, 2023

The multi-pool workflow doesn't exercise envoy in particular and the verbose logs make it harder to analyze logs. Disable them.

The multi-pool workflow doesn't exercise envoy in particular and the
verbose logs make it harder to analyze logs. Disable them.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/multipool Affects Multi-Pool IPAM labels Nov 3, 2023
@tklauser tklauser requested a review from gandro November 3, 2023 11:00
@tklauser tklauser requested review from a team as code owners November 3, 2023 11:00
@tklauser tklauser requested a review from brlbil November 3, 2023 11:00
@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2023

/ci-multi-pool

Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be backported to 1.14 as well.

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser
Copy link
Member Author

tklauser commented Nov 7, 2023

Reviews are in and the multi-pool workflow passed. This is the only CI workflow affected by this change, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2023
@squeed squeed merged commit 90ad1cd into main Nov 7, 2023
@squeed squeed deleted the pr/tklauser/ci-multi-pool-disable-envoy-tracing branch November 7, 2023 09:43
@jibi jibi mentioned this pull request Nov 7, 2023
15 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 7, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/multipool Affects Multi-Pool IPAM backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

6 participants