Skip to content

startup: improve speed of syncing CRDs #28954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

startup: improve speed of syncing CRDs #28954

merged 1 commit into from
Nov 8, 2023

Conversation

howardjohn
Copy link
Contributor

@howardjohn howardjohn commented Nov 2, 2023 •
edited by nathanjsweet
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Currently, startup is blocked waiting for CRDs to sync by a minimum of 1s. This very frequently is ready before 1s, but we only poll every 1s so we always pay the cost.

This drops the interval down to 50ms. This should have ~no cost, but improve startup speed by up to 950ms for all users.

init: Poll CRD synchronization times have been lowered from 1 second to 50ms.

@howardjohn
startup: improve speed of syncing CRDs
5c1e561 
Currently, startup is blocked waiting for CRDs to sync by a minimum of
1s. This very frequently is ready before 1s, but we only poll every 1s
so we always pay the cost.

This drops the interval down to 50ms. This should have ~no cost, but
improve startup speed by up to 950ms for all users.

Signed-off-by: John Howard <howardjohn@google.com>
@howardjohn howardjohn requested a review from a team as a code owner November 2, 2023 17:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 2, 2023
@nathanjsweet nathanjsweet added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 3, 2023
@nathanjsweet
Copy link
Member

/test

@nathanjsweet nathanjsweet added affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch labels Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 8, 2023
@squeed squeed merged commit fe91923 into cilium:main Nov 8, 2023
@pchaigno pchaigno mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howardjohn @nathanjsweet @squeed