restore full go vet behaviour #28945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
9de604a to
cfe4784
Compare
cfe4784 to
9d72400
Compare
Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Avoid copying the flow protobuf message, as this triggers go vet to complain about copying a mutex (in internal protobuf state). No functional changes intended, simply appeasing vet. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
Without -vet=all, go test doesn't run the same set of vets as go vet. Since we dropped go vet ./... from the integration tests, we weren't running the full suite anymore. Fixes: f6346d2 (make: drop redundant `go vet ./...` from integration tests) Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
9d72400 to
ca14e6d
Compare
tklauser
approved these changes
Nov 2, 2023
|
/test |
|
@bimmlerd LGTM |
|
Tests reliant on 1.1.1.1 are failing due to https://www.cloudflarestatus.com/incidents/hm7491k53ppg, I'll wait with retriggering until that is resolved. |
This was referenced Nov 3, 2023
|
/ci-ipsec-upgrade |
|
/ci-awscni |
|
/ci-clustermesh |
|
/ci-e2e |
|
/ci-eks |
|
/ci-ipsec-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three commits to fix up
go vet ./...which had regressed, and a fourth commit to reinstate running it as part of CI.This effectively reverts #26978, which seems fine as the PR which is linked as requiring it was never merged. Additionally, the work which seems to supersede it doesn't appear to require the deepcopy stuff #28873 (feel free to correct me here, @marqc).
cc @tklauser for the original change to drop
go vet.