Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 27, 2023

Description

Please refer to individual commit for more details. This is to prepare for v1.0.0 next week.

Add support for Gateway API v1.0

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 27, 2023
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch 3 times, most recently from 028163e to 0e3b9ac Compare October 28, 2023 00:47
@sayboras sayboras added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/k8s-gateway-api labels Oct 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 28, 2023
@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 0e3b9ac to c0dee32 Compare October 28, 2023 05:34
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch 4 times, most recently from 2202325 to 3e3ec24 Compare November 1, 2023 10:20
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/test

@sayboras sayboras marked this pull request as ready for review November 1, 2023 10:29
@sayboras sayboras requested review from a team as code owners November 1, 2023 10:29
@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 3e3ec24 to 571c432 Compare November 1, 2023 10:31
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/test

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 571c432 to d940d2a Compare November 1, 2023 11:27
@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/ci-gateway-api

@sayboras
Copy link
Member Author

sayboras commented Nov 1, 2023

/test

@sayboras sayboras requested a review from learnitall November 3, 2023 05:17
@sayboras
Copy link
Member Author

sayboras commented Nov 3, 2023

/test

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 18e5851 to 5e90a65 Compare November 3, 2023 05:20
@sayboras
Copy link
Member Author

sayboras commented Nov 3, 2023

/test

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 5e90a65 to 934516e Compare November 3, 2023 07:29
@sayboras
Copy link
Member Author

sayboras commented Nov 3, 2023

/test

@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 934516e to 38cbd51 Compare November 3, 2023 09:52
There is one small change in Gateway status in upstream, in which
HTTPRoute having ResolveRef as False is still allowed to be attached
into Gateway resource, but respective Gateway listener Programmed status
should be set as False.

Due to the bug in conformance test in v1.0.0, we need to use the commit
hash from upstream main branch.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
This commit is to enable two new features HTTPRouteBackendProtocolH2C
and HTTPRouteBackendProtocolWebSocket. Just notice that we can just
reverse the feature flags (e.g. supported vs exempt) for better
maintenance and faster lookup.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
We need to remove max stream duration to make the timeout effective in
route action, max stream duration can be also set http connection
manager. Another note that this feature is only available in the
experimental CRDs.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to enable HTTPResponseHeaderModification feature for standard
CRDs.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/gateway-api-1.0.0-rc2 branch from 38cbd51 to 717e45e Compare November 3, 2023 09:54
@sayboras
Copy link
Member Author

sayboras commented Nov 3, 2023

/test

Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 3, 2023
@sayboras sayboras merged commit a42ef40 into main Nov 3, 2023
@sayboras sayboras deleted the tam/gateway-api-1.0.0-rc2 branch November 3, 2023 23:25
@aanm aanm added release-note/major This PR introduces major new functionality to Cilium. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Nov 27, 2023
sayboras added a commit to sayboras/cilium that referenced this pull request Dec 12, 2023
This is to avoid the below warning log in cilium operator.

```
2023-12-12T11:03:51.648638037Z level=warning msg="The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1." subsys=klog
```

Relates: cilium#28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2023
This is to avoid the below warning log in cilium operator.

```
2023-12-12T11:03:51.648638037Z level=warning msg="The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1." subsys=klog
```

Relates: #28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
This is to avoid the below warning log in cilium operator.

```
2023-12-12T11:03:51.648638037Z level=warning msg="The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1." subsys=klog
```

Relates: cilium#28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to sayboras/cilium that referenced this pull request Jan 5, 2024
Relates: cilium#28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2024
Relates: #28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
jibi pushed a commit that referenced this pull request Jan 12, 2024
[ upstream commit f323319 ]

Relates: #28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
dylandreimerink pushed a commit that referenced this pull request Jan 15, 2024
[ upstream commit f323319 ]

Relates: #28836
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/k8s-gateway-api ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants