Skip to content

enabled initalDelaySeconds on StartupProbe #28816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

enabled initalDelaySeconds on StartupProbe #28816

merged 1 commit into from
Nov 2, 2023

Conversation

jignyasamishra
Copy link
Contributor

Enabled initalDelaySeconds on StartupProbe to avoid needless spamming of warnings by adding initialDelaySeconds of '5' seconds inside StartupProbe which is present in https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/templates/cilium-agent/daemonset.yaml and https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/templates/cilium-envoy/daemonset.yaml
Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #28574

@jignyasamishra jignyasamishra requested review from a team as code owners October 26, 2023 15:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Oct 26, 2023
gandro
gandro approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For reference, previous review: #28720 (comment)

@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Oct 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2023
@gandro gandro added the area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Oct 26, 2023
@gandro
Copy link
Member

gandro commented Oct 26, 2023

/test

meyskens
meyskens approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how sig-servicemesh got triggered by GitHub for a review... but from the service mesh side LGTM (aka it doesn't affect us)

@gandro
Copy link
Member

gandro commented Oct 30, 2023

@jignyasamishra There are some CI failures that I believe are caused by your branch being slightly out of date with main. Could you git rebase you branch on origin/main? Thanks!

@gandro
Copy link
Member

gandro commented Oct 31, 2023

Thanks! Please use rebase, not merge. We cannot merge branches with merge commits unfortunately.

@jignyasamishra
enabled initalDelaySeconds on StartupProbe
2fc335c 
Signed-off-by: jignyasamishra <iamjignyasa@gmail.com>
@jignyasamishra
Copy link
Contributor Author

Thank you so much!! Sorry for the delay. Is it good to go?

@aanm
Copy link
Member

aanm commented Oct 31, 2023

/test

@jignyasamishra
Copy link
Contributor Author

@gandro can we merge this PR? Or some changes are needed?

@gandro
Copy link
Member

gandro commented Nov 2, 2023

@gandro can we merge this PR? Or some changes are needed?

There are failing tests, which is why the "ready-to-merge" label is not automatically added. I've however triaged the required tests, and the failures are unrelated:

  • ci-ginko failed provisioning the VM
  • ci-runtime also seemed to have troubles provisioning the VMs

I'll restart all failed tests and once CI is green, this is ready to merge.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 2, 2023
@joamaki joamaki merged commit f911b12 into cilium:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@squeed squeed squeed approved these changes

@joamaki joamaki joamaki approved these changes

+1 more reviewer

@meyskens meyskens meyskens approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: enable initalDelaySeconds on StartupProbe
6 participants
@jignyasamishra @gandro @aanm @squeed @joamaki @meyskens