Test upgrade/downgrade to patch release for IPsec #28815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffb9ea2 to
df4533d
Compare
This was referenced Nov 9, 2023
df4533d to
93bf6e4
Compare
|
/test |
|
/ci-ipsec-upgrade |
f45234b to
d933888
Compare
|
/test |
pchaigno
reviewed
Nov 21, 2023
d933888 to
91a2888
Compare
|
Since the previous version, I simply fixed the mistake reported by Paul. |
Skip upgrade/downgrade test to patch release when we fail to retrieve the number for the previous patch release. This happens mostly for the main branch (where testing upgrades/downgrades is covered by the tests to the previous stable (minor) release already). This may also happen on top of release preparation commits, where we set the patch number to 90, and where it is non-trivial to retrieve the previous patch release number. This case doesn't matter much, because commits for preparing releases are Not Expected To Break IPsec (TM). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
91a2888 to
40cf054
Compare
|
@julianwiedmann Good thing you asked, this commit description is wrong indeed. I wrote it the other way initially, but apparently I got confused at some point and changed to the actual, mistaken description - then forgot to check it a final time before pushing 🤔. Anyway, I just fixed it. |
|
/test |
julianwiedmann
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
@julianwiedmann Good thing you asked, this commit description is wrong indeed. I wrote it the other way initially, but apparently I got confused at some point and changed to the actual, mistaken description - then forgot to check it a final time before pushing 🤔. Anyway, I just fixed it.
Thank you!
pchaigno
approved these changes
Nov 22, 2023
3 tasks
pchaigno
reviewed
Dec 10, 2023
This was referenced Dec 11, 2023
joestringer
reviewed
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Corresponding backport PRs: