Skip to content

Update cilium status command module health output #28800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update cilium status command module health output #28800

merged 1 commit into from
Nov 7, 2023

Conversation

derailed
Copy link
Contributor

@derailed derailed commented Oct 25, 2023 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

To date, we render modules health information as tabular data. As modules health instrumentation grows this rendering makes it hard for users to grok the output. This PR proposes changing the rendering of modular health using a tree like structure to give users a better line of sight to gain an understanding of the agent modules health state.

Fixes: #issue-number

Changed cilium status CLI output to render the modules health section as a tree structure vs tabular data.

Signed-off-by: Fernand Galiana fernand.galiana@gmail.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2023
@derailed derailed force-pushed the pr/mh_status_tree branch 4 times, most recently from 1b859b5 to b9bf489 Compare October 25, 2023 23:10
@derailed derailed marked this pull request as ready for review October 25, 2023 23:44
@derailed derailed requested review from a team as code owners October 25, 2023 23:44
tklauser
tklauser reviewed Oct 26, 2023
View reviewed changes
@derailed derailed force-pushed the pr/mh_status_tree branch 2 times, most recently from 83a666e to 9a0cf30 Compare October 26, 2023 13:52
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Oct 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 27, 2023
@pippolo84 pippolo84 self-requested a review October 27, 2023 08:46
@ti-mo ti-mo removed the request for review from rgo3 October 27, 2023 08:46
@ti-mo
Copy link
Contributor

ti-mo commented Oct 27, 2023

@derailed Could you update the release note in the PR description?

@derailed
Copy link
Contributor Author

/test

pippolo84
pippolo84 reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I'd left some questions inline.

@derailed derailed force-pushed the pr/mh_status_tree branch 3 times, most recently from db7b63f to 5351c2a Compare October 27, 2023 21:21
@tommyp1ckles tommyp1ckles mentioned this pull request Oct 29, 2023
Merged
tommyp1ckles
tommyp1ckles reviewed Oct 29, 2023
View reviewed changes
@pippolo84 pippolo84 self-requested a review October 31, 2023 16:58
@derailed derailed force-pushed the pr/mh_status_tree branch 3 times, most recently from d599446 to e1b7309 Compare November 1, 2023 16:11
tommyp1ckles
tommyp1ckles reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output looks great! - thanks working around the last set of changes to the reporter.

Just a few comments

@derailed
Copy link
Contributor Author

derailed commented Nov 2, 2023

/test

tommyp1ckles
tommyp1ckles approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

pippolo84
pippolo84 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀
A couple of non-blocking nits left inline.

@derailed
Update cilium status command module health output
411cc3f 
To date, we render modules health information as tabular data. As modules
health instrumentation grows this rendering makes it hard for users to
grok the output. This PR proposes changing the rendering of modular
health using a tree like structure to give users a better line of sight
to gain a better understanding of the agent modules state.

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed
Copy link
Contributor Author

derailed commented Nov 3, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2023
@tklauser tklauser merged commit 85d8e6a into cilium:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@derailed @ti-mo @tklauser @pippolo84 @tommyp1ckles @jrajahalme