Skip to content

Add node activity health reporters on node manager #28799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add node activity health reporters on node manager #28799

merged 1 commit into from
Nov 6, 2023

Conversation

derailed
Copy link
Contributor

@derailed derailed commented Oct 25, 2023 •
edited by dylandreimerink
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Add instrumentation to node manager to provide module health reporting when node
CRUD operations are detected.

Add node activity health reporters on node manager

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2023
@derailed derailed force-pushed the pr/add_node_health_reporter branch from 1c42e1f to ed1069c Compare October 25, 2023 21:46
@derailed
Copy link
Contributor Author

/test

@derailed derailed marked this pull request as ready for review October 25, 2023 23:43
@derailed derailed requested review from a team as code owners October 25, 2023 23:43
@derailed derailed requested review from danehans and brb October 25, 2023 23:43
danehans
danehans suggested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a few minor pieces of feedback:

  • Changes are included that are inconsistent with the PR's description. Please use a separate PR for the changes unrelated to adding the health reporter.
  • It would be helpful to create and link an issue to provide additional context for the PR.

@derailed derailed force-pushed the pr/add_node_health_reporter branch from ed1069c to aaff90e Compare October 27, 2023 20:26
@derailed
Copy link
Contributor Author

@danehans Thank you for the review and comments! I'll update accordingly...

@derailed
Copy link
Contributor Author

/test

@derailed derailed force-pushed the pr/add_node_health_reporter branch from aaff90e to d35a267 Compare October 27, 2023 22:52
@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Oct 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2023
@derailed
Copy link
Contributor Author

/test

@danehans danehans self-requested a review October 30, 2023 15:32
@derailed
Augment node manager module health reporting
0855005 
Add instrumentation to node manager to provide module health reporting when node
CRUD operations are detected.

Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
@derailed derailed force-pushed the pr/add_node_health_reporter branch from d35a267 to 0855005 Compare October 31, 2023 22:31
@derailed
Copy link
Contributor Author

/test

brb
brb approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 6, 2023
@aditighag aditighag merged commit f0d2d78 into cilium:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

+1 more reviewer

@danehans danehans danehans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@derailed @brb @danehans @dylandreimerink @aditighag