Skip to content

Some small fixes to make kind-fast #28621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2023
Merged

Some small fixes to make kind-fast #28621

merged 2 commits into from
Nov 7, 2023

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Oct 16, 2023

Two fixes:

  1. Stop unnecessarily deleting agent pods. There was a bug where all agent pods were deleted for all nodes, rather than once per rollout
  2. Stop unnecessarily pulling the base image. Images with the :latest tag have an ImagePullPolicy defaulted to Always, which is a waste of bandwidth and time.

@squeed squeed requested review from a team as code owners October 16, 2023 14:57
@squeed squeed requested review from aditighag and jibi October 16, 2023 14:57
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 16, 2023
@squeed squeed requested a review from aanm October 16, 2023 14:57
@squeed squeed added the area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. label Oct 16, 2023
aanm
aanm requested changes Oct 16, 2023
View reviewed changes
aditighag
aditighag reviewed Oct 16, 2023
View reviewed changes
@squeed
kind-image-fast-*: stop deleting pods for every node
58e66a8 
The loop inadvertently restarted all cilium pods once **for every node**
rather than once per cluster. Oops.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed force-pushed the kind-fast-fix-restart branch from 528fb74 to df32efb Compare October 17, 2023 09:36
@squeed squeed requested a review from aanm October 17, 2023 09:37
aanm
aanm approved these changes Oct 17, 2023
View reviewed changes
@squeed
devel: stop kind from unnecessarily pulling images
1353e67 
Because `make kind-install` can default to a :latest image, the kubelet
will pull images on every restart. This makes restarts use unnecessary
bandwidth.

So, change the ImagePullPolicy to IfNotPresent. Also, pre-load the image
via `kind load docker-image` to prevent all the nodes pulling the image
in parallel.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed force-pushed the kind-fast-fix-restart branch from df32efb to 1353e67 Compare October 18, 2023 14:44
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Oct 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 18, 2023
@squeed squeed added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 3, 2023
@squeed
Copy link
Contributor Author

squeed commented Nov 3, 2023

Marking as ready-to-merge; all approvals are in and this is some development tooling.

@aanm aanm merged commit 1c1b7eb into cilium:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag left review comments

@jibi jibi jibi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@squeed @jibi @aanm @aditighag