Modularize bandwidth manager #28619
Merged
Modularize bandwidth manager #28619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a834899 to
a7436a2
Compare
|
/test |
a7436a2 to
272b937
Compare
|
/test |
272b937 to
cc555ff
Compare
|
/ci-clustermesh |
cc555ff to
c753a8a
Compare
|
/test |
c753a8a to
c85b6a1
Compare
|
/ci-clustermesh |
c85b6a1 to
ca2a008
Compare
|
/test |
ca2a008 to
97b30b5
Compare
|
/test |
97b30b5 to
b0875f1
Compare
|
/test |
b0875f1 to
e7037ba
Compare
|
/test |
e7037ba to
ac95bc9
Compare
|
/test |
joamaki
reviewed
Oct 23, 2023
joamaki
reviewed
Oct 23, 2023
joamaki
reviewed
Oct 23, 2023
joamaki
reviewed
Oct 23, 2023
ac95bc9 to
1c2b269
Compare
e9e7c51 to
526532a
Compare
asauber
approved these changes
Nov 1, 2023
joamaki
reviewed
Nov 2, 2023
lmb
requested changes
Nov 2, 2023
aditighag
reviewed
Nov 2, 2023
tommyp1ckles
reviewed
Nov 3, 2023
|
K8s changes look good 🚀 ... just some random comments/questions. |
526532a to
b5b7989
Compare
aditighag
approved these changes
Nov 6, 2023
tommyp1ckles
approved these changes
Nov 6, 2023
lmb
approved these changes
Nov 7, 2023
|
Thanks for switching to the extra defines thingie. |
Would have been a bit dumb to do all that work to introduce it and then not use it 😁 |
marseel
reviewed
Nov 13, 2023
In preparation of adding more inputs to the linux datapath NewDatapath func, pull out the dependencies into a struct. Signed-off-by: David Bimmler <david.bimmler@isovalent.com> Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Minor cleanups for how this cell looks and reads, in preparation of runtime device detection work which will further extend the configWriterParameters. Changed the module name to match the subsystem log field that was used previously. Signed-off-by: Jussi Maki <jussi@isovalent.com> Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
This work moves the bandwidth manager to the datapath package and turns it into a cell. It is now provided via hive or via arguments from a component that is itself a cell. Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
b5b7989 to
9e2dd6f
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming some modularization changes while working on runtime device detection, these are in preparation of removing option.Config.GetDevices and replacing it with a devices table, which requires depending subsystems to be in hive.
In theory, this should not contain functional changes, but in practice there's some questions around the order of operations, specifically in the commit modularizing the bandwidth manager.