Skip to content

bpf: fine-tune a few L3 header validations #28669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2023
Merged

bpf: fine-tune a few L3 header validations #28669

merged 2 commits into from
Nov 3, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Oct 18, 2023 •
edited
Loading

Lift two revalidate_data() users out of their current location, so that callers can pass a L3 header if already available.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 18, 2023
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 18, 2023
@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-lxc-revalidate branch from ee3afd9 to cefc76a Compare October 18, 2023 07:02
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-lxc-revalidate branch from cefc76a to 18a077e Compare October 19, 2023 04:04
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
bpf: lxc: pass L3 header to ipv*_policy()
ba1b59d 
In the tail_ipv*_to_endpoint() path we already have a validated L3 header.
Make it possible to pass this header to ipv*_policy().

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: proxy: pass IPv4 header to ctx_redirect_to_proxy_hairpin()
cf6e411 
Avoid re-validating the IPv4 header when called from nodeport_lb4().

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-lxc-revalidate branch from 18a077e to cf6e411 Compare October 25, 2023 05:22
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title 1.15 bpf lxc revalidate bpf: fine-tune a few L3 header validations Oct 25, 2023
@julianwiedmann julianwiedmann added the kind/cleanup This includes no functional changes. label Oct 25, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review October 25, 2023 10:00
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 25, 2023 10:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 3, 2023
@julianwiedmann julianwiedmann merged commit 6e7b22a into cilium:main Nov 3, 2023
@julianwiedmann julianwiedmann deleted the 1.15-bpf-lxc-revalidate branch November 3, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianwiedmann @ldelossa