don't remove neighbor link state file if migrateOnly #28659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit c342806 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
c342806 to
5569404
Compare
borkmann
approved these changes
Oct 27, 2023
|
/test |
NodeCleanNeighbors is also called when enable-l2-neigh-discovery with migrateOnly==false. In that case, all existing arp entries can still be removed because neighLastPingByNextHop is still empty (https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013). The neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113 The file is only resotred again when next time NodeConfigurationChanged() is called. This can break arp entry cleanup when next time cilium is started without enable-l2-neigh-discovery Signed-off-by: Yuan Liu <liuyuan@google.com>
5569404 to
83f9911
Compare
|
/test |
|
IPSec review no longer needed (in fact, it was removed from this file in a subsequent PR). All required tests are passing. Marking as ready-to-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeCleanNeighbors is also called when enable-l2-neigh-discovery with migrateOnly==false. In that case, all existing arp entries can still be removed because neighLastPingByNextHop is still empty (https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013). The neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113
The file is only resotred again when next time
NodeConfigurationChanged() is called.
This can break arp entry cleanup when next time cilium is started without enable-l2-neigh-discovery