Skip to content

pkg/bgpv1: Updates getPeerConfig() Method #28474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

pkg/bgpv1: Updates getPeerConfig() Method #28474

merged 1 commit into from
Nov 22, 2023

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Oct 9, 2023 •
edited
Loading

  • Adds nil checks for Neighbor and EBGPMultihopTTL types.
  • Adds unit test.

Fixes: #28363

@danehans danehans requested a review from a team as a code owner October 9, 2023 21:20
@danehans danehans requested a review from ldelossa October 9, 2023 21:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 9, 2023
@danehans danehans force-pushed the issue_28363 branch 3 times, most recently from e57eddf to 8db778b Compare October 23, 2023 18:48
ldelossa
ldelossa reviewed Oct 24, 2023
View reviewed changes
@danehans danehans changed the title pkg/bgpv1: Adds Unit Test for getPeerConfig() Method pkg/bgpv1: Updates getPeerConfig() Method Oct 25, 2023
@danehans
Copy link
Contributor Author

Commit b5e58f2 rebases to try fixing k8s conformance CI flake.

@danehans
Copy link
Contributor Author

/test

@dylandreimerink dylandreimerink added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Oct 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 30, 2023
@dylandreimerink dylandreimerink added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Oct 30, 2023
@danehans danehans requested a review from ldelossa November 2, 2023 15:12
@danehans
Copy link
Contributor Author

danehans commented Nov 2, 2023

/ci-runtime

@danehans
Copy link
Contributor Author

danehans commented Nov 2, 2023

/ci-ipsec-upgrade

@danehans
Copy link
Contributor Author

danehans commented Nov 3, 2023

/test

@danehans
Copy link
Contributor Author

danehans commented Nov 6, 2023

/ci-clustermesh

@danehans
Copy link
Contributor Author

danehans commented Nov 6, 2023

/ci-e2e

@danehans
Copy link
Contributor Author

Commit 64d56c9 rebases to fix CI flakes.

ldelossa
ldelossa approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@ldelossa
Copy link
Contributor

/test

@danehans
pkg/bgpv1: Updates getPeerConfig() Method
fb81256 
- Adds nil checks for Neighbor and EBGPMultihopTTL types.
- Adds unit test.

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
Copy link
Contributor Author

/test

@danehans
Copy link
Contributor Author

/ci-ginkgo

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 21, 2023
@lmb lmb merged commit 0a16044 into cilium:main Nov 22, 2023
mhofstetter added a commit to mhofstetter/cilium that referenced this pull request Nov 22, 2023
@mhofstetter
bgpv1: fix merge race conflict on NewGoBGPServer
6774987 
This commit fixes the build caused by a merge race between
the following PRs

cilium#28474
cilium#29277

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter mentioned this pull request Nov 22, 2023
Merged
gandro pushed a commit that referenced this pull request Nov 22, 2023
@mhofstetter @gandro
bgpv1: fix merge race conflict on NewGoBGPServer
7cfa82b 
This commit fixes the build caused by a merge race between
the following PRs

#28474
#29277

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this pull request Dec 15, 2023
@mhofstetter @pjablonski123
bgpv1: fix merge race conflict on NewGoBGPServer
2884373 
This commit fixes the build caused by a merge race between
the following PRs

cilium#28474
cilium#29277

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@danehans danehans deleted the issue_28363 branch March 8, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/bgpv1: Add Unit Tests for getPeerConfig() Method
4 participants
@danehans @ldelossa @lmb @dylandreimerink