Skip to content

bpf: lxc: remove stale ENABLE_IDENTITY_MARK ifdefs #28391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

bpf: lxc: remove stale ENABLE_IDENTITY_MARK ifdefs #28391

merged 1 commit into from
Oct 9, 2023

Conversation

julianwiedmann
Copy link
Member

4de20fc ("bpf: Pass security ID via skb->cb from lxc to host") switched these parts from using set_identity_mark() to set_identity_meta(). Thus we no longer have to respect the opt-in that controls whether the skb mark may be used to store the identity.

@julianwiedmann
bpf: lxc: remove stale ENABLE_IDENTITY_MARK ifdefs
3871276 
4de20fc ("bpf: Pass security ID via skb->cb from lxc to host")
switched these parts from using set_identity_mark() to
set_identity_meta(). Thus we no longer have to respect the opt-in that
controls whether the skb mark may be used to store the identity.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels Oct 4, 2023
@julianwiedmann julianwiedmann requested review from a team and gentoo-root and removed request for a team October 4, 2023 07:58
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 4, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
Copy link
Member Author

I'm undecided on whether this is a bug fix vs enhancement. Opinions? :)

@julianwiedmann julianwiedmann marked this pull request as ready for review October 4, 2023 10:27
@julianwiedmann julianwiedmann requested a review from a team as a code owner October 4, 2023 10:27
gentoo-root
gentoo-root approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@gentoo-root gentoo-root left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm undecided on whether this is a bug fix vs enhancement. Opinions? :)

Looks more like an enhancement to me.

@julianwiedmann
Copy link
Member Author

I'm undecided on whether this is a bug fix vs enhancement. Opinions? :)

Looks more like an enhancement to me.

Given that it most likely didn't work before either? Yeah that's fair, thank you! We can always backport later if needed.

@julianwiedmann julianwiedmann added kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels Oct 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Oct 9, 2023
@julianwiedmann julianwiedmann merged commit 414814f into cilium:main Oct 9, 2023
@julianwiedmann julianwiedmann deleted the 1.15-bpf-ipsec branch October 9, 2023 07:43
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Oct 24, 2023
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
14 tasks
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
6 tasks
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
6 tasks
@tklauser tklauser added backport-pending/1.12 backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.12 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 24, 2023
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 26, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
This was referenced Nov 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.13.9
Status: Released
cilium v1.14.4
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @gentoo-root @tklauser