Skip to content

Conversation

learnitall
Copy link
Contributor

@learnitall learnitall commented Oct 2, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

This commit acts as an initial effort to add automated scale testing to Cilium, as described in cilium/design-cfps#11. The workflow added as part of this commit is meant to lay down a foundation that can be built upon, with the intent that it will be iteratively developed on to carry out the CFP. The workflow currently performs the following:

  • Create a two-node GCE cluster using kops
  • Run a bare-bones ClusterLoader2 configuration
  • Cleanup the cluster

The following next steps are a WIP:

  • Expand on the ClusterLoader2 configuration
  • Increase the number of nodes in the cluster
  • Export results from ClusterLoader2
  • Allow for manual runs using WorkflowDispatch

Note: ClusterLoader2 is currently pulled from a fork containing changes that are intended to be merged upstream in the coming week.

Fixes: #27749

Add initial, in-progress workflow for automated scale testing

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@learnitall learnitall force-pushed the pr/learnitall/100-node-scale-test-cl2 branch from 0804112 to 375c0e1 Compare October 2, 2023 22:12
@learnitall learnitall added dont-merge/preview-only Only for preview or testing, don't merge it. kind/performance There is a performance impact of this. release-note/ci This PR makes changes to the CI. labels Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2023
@learnitall learnitall force-pushed the pr/learnitall/100-node-scale-test-cl2 branch 5 times, most recently from 82481a7 to 9de33fd Compare October 5, 2023 20:21
@learnitall learnitall marked this pull request as ready for review October 5, 2023 21:25
@learnitall learnitall requested review from a team as code owners October 5, 2023 21:25
@learnitall learnitall requested a review from brlbil October 5, 2023 21:25
This commit acts as an initial effort to add automated scale testing to
Cilium, as described in cilium/design-cfps#11.
The workflow added as part of this commit is meant to lay down a
foundation that can be built upon, with the intent that it will be
iteratively developed on to carry out the CFP. The workflow currently
performs the following:

* Create a two-node GCE cluster using kops
* Run a bare-bones ClusterLoader2 configuration
* Cleanup the cluster

The following next steps are a WIP:

* Expand on the ClusterLoader2 configuration
* Increase the number of nodes in the cluster
* Export results from ClusterLoader2
* Allow for manual runs using WorkflowDispatch

Note: ClusterLoader2 is currently pulled from a fork containing changes
that are intended to be merged upstream in the coming week.

Fixes: #27749

Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall force-pushed the pr/learnitall/100-node-scale-test-cl2 branch from 9de33fd to 1fc9b5a Compare October 6, 2023 18:05
@learnitall learnitall requested a review from brlbil October 6, 2023 18:06
@learnitall learnitall removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Oct 6, 2023
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@learnitall
Copy link
Contributor Author

Before doing a force push to remove items from the workflow that were needed for testing (a push trigger), this was the last successful run: https://github.com/cilium/cilium/actions/runs/6424076662/job/17443936075. Since this PR just adds a new workflow file and doesn't make any other changes, I don't believe it needs the full test suite. Therefore, I'm going to mark this as ready to merge.

@learnitall learnitall added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 10, 2023
@squeed squeed merged commit 693f2bd into main Oct 11, 2023
@squeed squeed deleted the pr/learnitall/100-node-scale-test-cl2 branch October 11, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap GHA for scale-testing
3 participants