-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Split mapstate keys into allow and deny #28352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split mapstate keys into allow and deny #28352
Conversation
714daaa
to
2fb53b8
Compare
/test |
4bd82fd
to
7e771e7
Compare
/test |
7e771e7
to
477f805
Compare
/ci-ginkgo |
/test |
/ci-gateway-api Rerunning. Filed #28374 for the issue which occurred. |
@bimmlerd Changed v1.12 backport label to needs-backport/1.12 to be able to complete the release process. Looks like we can't have any pending backports when doing the release. |
@bimmlerd Added backport/author label because I assume you'll take care of manually backporting this. Automated backports are leading to merge conflicts. |
removing backport-pending labels here, as the project has decided against backporting this change -- it's too invasive for extensive backporting. |
The first commit converts the MapState type from a newtype an interface (mostly Nate's work, rebased on newer
main
)The second commit then splits the map in the struct into two - to track allows and denies seperately.
This allows for an optimization in the third commit:
denyPreferredInserts
for the allow case, now doesn't have to loop through all other allows (which we don't care about).Commit msgs for convenience:
policy: Make MapState an interface
mapstate: split allows and denies
mapstate: optimize denyPreferredInsert