contrib/kind: custom kind values #28155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3814ff to
a81cec5
Compare
|
/test |
bimmlerd
approved these changes
Sep 14, 2023
ca4e13e to
a0fec5d
Compare
Thanks for your input @bimmlerd ! I added an additional section in the Development Setup. In addition i adapted the changes for the |
zacharysarah
requested changes
Sep 14, 2023
There was a problem hiding this comment.
@mhofstetter One tiny nit and one optional suggestion, otherwise LGTM
The Make targets to deploy Cilium into a kind cluster are using the following Helm values files. * contrib/testing/kind-values.yaml * contrib/testing/kind-fast.yaml These contain reasonable defaults. Nevertheless, it would be great to be able to define additional helm values without having to modify the existing files. Therefore, this commit introduces the possibilitiy to define a user-defined values file that is added to the list of helm values files. * contrib/testing/kind-custom.yaml To prevent users from committing the file, it's ignored by Git. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
a0fec5d to
59d908e
Compare
|
/test |
jibi
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Make targets to deploy Cilium into a kind cluster are using the following Helm values files.
contrib/testing/kind-common.yamlcontrib/testing/kind-values.yamlcontrib/testing/kind-fast.yamlThese contain reasonable defaults. Nevertheless, it would be great to be able to define additional helm values without having to modify the existing files.
Therefore, this commit introduces the possibility to define a user-defined values file that is added to the list of helm values files.
contrib/testing/kind-custom.yamlTo prevent users from committing the file, it's ignored by Git.