Rename the CLI for local Cilium API access to 'cilium-dbg' #28085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1493313 to
a7ad942
Compare
635220e to
18f20ed
Compare
|
/test |
df8f4be to
bd9437f
Compare
|
/test |
|
The Conformance External Workloads (ci-external-workloads) requires a fresh release of cilium-cli including cilium/cilium-cli#2006 and to bump the CLI versions used in GitHub workflows, but other than that the required tests are all passing now. Opening for review. |
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
This commit changes most of the existing shell commands for the local Cilium API over to 'cilium-dbg', but skips the core helpers. The reason for this is that the core helpers are used by the Updates test which runs the commands against an older version of Cilium. As such, we cannot replace those commands with 'cilium-dbg' until the next development version when we start updating from a Cilium copy that has the 'cilium-dbg' binary inside. Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Joe Stringer <joe@cilium.io>
bd9437f to
aaa504a
Compare
|
/test |
|
Hey @YutaroHayakawa , any chance of a review for your codeowners? |
YutaroHayakawa
approved these changes
Oct 11, 2023
|
Sorry for the late. Looks good to me! |
sayboras
added a commit
that referenced
this pull request
Oct 16, 2023
This is to fix the below issue: ``` Warning Failed 8m3s (x5 over 9m31s) kubelet Error: failed to start container "config": Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "cilium": executable file not found in $PATH: unknown ```` Relates: #28085
sayboras
added a commit
that referenced
this pull request
Oct 16, 2023
This is to fix the below issue: ``` Warning Failed 8m3s (x5 over 9m31s) kubelet Error: failed to start container "config": Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "cilium": executable file not found in $PATH: unknown ```` Relates: #28085 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
that referenced
this pull request
Oct 17, 2023
This is to fix the below issue: ``` Warning Failed 8m3s (x5 over 9m31s) kubelet Error: failed to start container "config": Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "cilium": executable file not found in $PATH: unknown ```` Relates: #28085 Signed-off-by: Tam Mach <tam.mach@cilium.io>
joestringer
pushed a commit
that referenced
this pull request
Oct 1, 2024
#28085 erroneously changed cilium-health command, reverting Signed-off-by: Andrii Iuspin <57713382+ayuspin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: cilium/cilium-cli#2002
Requires: #28406
Requires: cilium/cilium-cli#2006