Skip to content

Clean up tests-ipsec-upgrade workflow #27977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Clean up tests-ipsec-upgrade workflow #27977

merged 1 commit into from
Sep 7, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Sep 6, 2023 •
edited
Loading

  • Add a script to get the Cilium version to downgrade to instead of
    hardcoding it in the workflow file. The script uses the top-level
    VERSION file to infer the previous version.
  • Check out the git branch to get the Helm chart instead of doing a wget
    to download the source archive.

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 6, 2023
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent force-pushed the pr/michi/magical-script branch from feaf61b to 90e9ba7 Compare September 6, 2023 20:34
@michi-covalent
Copy link
Contributor Author

/ci-ipsec-upgrade

@michi-covalent michi-covalent force-pushed the pr/michi/magical-script branch from 90e9ba7 to 5803971 Compare September 6, 2023 21:19
@michi-covalent
Copy link
Contributor Author

/ci-ipsec-upgrade

@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Sep 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 6, 2023
@michi-covalent
Clean up tests-ipsec-upgrade workflow
aa4b19d 
- Add a script to get the Cilium version to downgrade to instead of
  hardcoding it in the workflow file. The script uses the top-level
  VERSION file to infer the previous version.
- Check out the git branch to get the Helm chart instead of doing a wget
  to download the source archive.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent force-pushed the pr/michi/magical-script branch from 5803971 to aa4b19d Compare September 6, 2023 22:18
@michi-covalent michi-covalent changed the title struggle testing Clean up tests-ipsec-upgrade workflow Sep 6, 2023
@michi-covalent
Copy link
Contributor Author

/test

@michi-covalent michi-covalent marked this pull request as ready for review September 7, 2023 00:40
@michi-covalent michi-covalent requested review from a team as code owners September 7, 2023 00:40
viktor-kurchenko
viktor-kurchenko reviewed Sep 7, 2023
View reviewed changes
brb
brb approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 7, 2023
@michi-covalent michi-covalent merged commit d51a932 into main Sep 7, 2023
@michi-covalent michi-covalent deleted the pr/michi/magical-script branch September 7, 2023 14:18
This was referenced Nov 9, 2023
Merged
Merged
Merged
@qmonnet qmonnet added needs-backport/1.12 backport/author The backport will be carried out by the author of the PR. labels Nov 9, 2023
@qmonnet qmonnet added needs-backport/1.13 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.12 labels Nov 9, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.12 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 28, 2023
This was referenced Dec 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-kurchenko viktor-kurchenko viktor-kurchenko left review comments

@brb brb brb approved these changes

@nebril nebril nebril approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
cilium v1.12.17
Status: Released
cilium v1.13.10
Status: Released
cilium v1.14.5
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michi-covalent @brb @nebril @jschwinger233 @viktor-kurchenko @qmonnet