Skip to content

Conversation

giorio94
Copy link
Member

Move the registration of the flags to enable/disable k8s EndpointSlices and tune the service proxy configuration to the resources cell, so that we uniform it in all components relying on it.

@giorio94 giorio94 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Aug 30, 2023
@giorio94 giorio94 force-pushed the mio/k8s-resources-flag branch from 03e80c2 to 9a24677 Compare August 30, 2023 07:50
@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 force-pushed the mio/k8s-resources-flag branch from 9a24677 to bc2063c Compare August 30, 2023 10:01
@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

Rebased onto main to pick CI changes

@giorio94
Copy link
Member Author

/test

@giorio94
Copy link
Member Author

giorio94 commented Aug 30, 2023

/test

Tests timed out while waiting for images

Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BGP changes lgtm

@christarazi christarazi added area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. area/agent Cilium agent related. labels Aug 30, 2023
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusterMesh part looks good 👍

@giorio94 giorio94 force-pushed the mio/k8s-resources-flag branch from e25e2ff to 68a92bd Compare August 31, 2023 08:34
@giorio94
Copy link
Member Author

Rebased onto main to fix conflicts

@giorio94
Copy link
Member Author

/test

@giorio94 giorio94 force-pushed the mio/k8s-resources-flag branch from 68a92bd to cf24844 Compare September 1, 2023 16:01
@giorio94
Copy link
Member Author

giorio94 commented Sep 1, 2023

Rebased onto main to pick CI changes

@giorio94
Copy link
Member Author

giorio94 commented Sep 1, 2023

/test

@giorio94
Copy link
Member Author

giorio94 commented Sep 1, 2023

@derailed Ping 🙏

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorio94 LGTM. couple picks...

@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 5, 2023
@tklauser tklauser added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 6, 2023
@tklauser tklauser added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 6, 2023
@tklauser
Copy link
Member

tklauser commented Sep 6, 2023

Looks like this PR needs a rebase.

Move the registration of the flags to enable/disable k8s EndpointSlices
and tune the service proxy configuration to the resources cell, so that
we uniform it in all components relying on it.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the mio/k8s-resources-flag branch from cf24844 to fce25b1 Compare September 18, 2023 12:08
@giorio94 giorio94 removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Sep 18, 2023
@giorio94
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 18, 2023
@tklauser tklauser merged commit e782654 into cilium:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Cilium agent related. area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants