-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Register service/endpoint flags through hive #27817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
03e80c2
to
9a24677
Compare
/test |
9a24677
to
bc2063c
Compare
/test |
bc2063c
to
e25e2ff
Compare
Rebased onto main to pick CI changes |
/test |
/test Tests timed out while waiting for images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BGP changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ClusterMesh part looks good 👍
e25e2ff
to
68a92bd
Compare
Rebased onto main to fix conflicts |
/test |
68a92bd
to
cf24844
Compare
Rebased onto main to pick CI changes |
/test |
@derailed Ping 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giorio94 LGTM. couple picks...
Looks like this PR needs a rebase. |
Move the registration of the flags to enable/disable k8s EndpointSlices and tune the service proxy configuration to the resources cell, so that we uniform it in all components relying on it. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
cf24844
to
fce25b1
Compare
/test |
Move the registration of the flags to enable/disable k8s EndpointSlices and tune the service proxy configuration to the resources cell, so that we uniform it in all components relying on it.