-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ci: add conformance-ginkgo-race-detection #27797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Duplicate the ginkgo workflow but with the race detection ci images. Fixes: cilium#26170 Signed-off-by: Mark Pashmfouroush <mark@isovalent.com>
I've duplicated the workflow, but not sure exactly how to test that this works as it should. I'd love some advice on how I can test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will people remember to update the two workflows at the same time?
Given that the triggers are the same as the Ginkgo workflow, would it make sense instead to extend the Matrix to run with the race images as well, rather than duplicating the workflow entirely?
I'd love some advice on how I can test this.
Not sure if it will work, but from your changes in the ariane-config.yaml
, let's try /ci-gingko
?
# Warning: since this is a privileged workflow, subsequent workflow job | ||
# steps must take care not to execute untrusted code. | ||
- name: Checkout pull request branch (NOT TRUSTED) | ||
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is outdated w.r.t. the current ginkgo workflow in the main
branch.
Same for all other uses of actions/checkout
, and for setup-go
.
/ci-ginkgo |
Well the idea was to initially get this workflow in and running, and then once we know it works, figure out how to dedup it.
I'm not very opinionated on this, perhaps @nbusseneau has some ideas?
Oh, I wasn't sure that I could run workflows from a fork. |
It will indeed not run from a fork, you will need to re-open your PR with a branch located on upstream :) I would suggest using a separate trigger in Ariane config to be able to trigger only that workflow, and there is a special trick you need to do to get your new workflow to register when you open the PR: add a temporary As for structure: for testing let's just do it copy/pasted for now, when we are happy with how it works I would suggest we look into merging the changes in the main Ginkgo workflow file, so that only one file needs to be maintained. One idea I have is to leverage the Let me know if you need help with anything :) |
This pull request has been automatically marked as stale because it |
Duplicate the ginkgo workflow but with the race detection ci images.
Fixes: #26170