Import new version of forked controller-tools #26918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in this PR make sense to me, but I would wait for Chris if we want to create the tag v0.6.1 (aligned with upstream), so that we can just have v0.6.1-- in go.mod. |
Manually created tag v0.6.2-1 is used in place of automatically generated v0.3.1-0.20230718144332-69030211a4bc. Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
44c6888 to
2944c28
Compare
christarazi
approved these changes
Jul 20, 2023
|
/test |
sayboras
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manually created tag
v0.6.2-1is used in place of automatically generatedv0.3.1-0.20230718144332-69030211a4bc(which was not intuitive).It is required by #26646