Skip to content

Add deepcopy plugin #26978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add deepcopy plugin #26978

merged 3 commits into from
Jul 26, 2023

Conversation

AwesomePatrol
Copy link
Contributor

It is required by #26646, so I could include the FlowFilter proto in the generated CRD.

After this change is merged I will use the updated builder image for code generation.

@AwesomePatrol AwesomePatrol requested review from a team as code owners July 21, 2023 09:13
@AwesomePatrol AwesomePatrol requested a review from kaworu July 21, 2023 09:13
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2023
@AwesomePatrol AwesomePatrol requested review from a team as code owners July 21, 2023 09:26
@AwesomePatrol
Copy link
Contributor Author

I guess I don't have sufficient permissions to run images/scripts/update-cilium-builder-image.sh or am I doing something wrong?

@AwesomePatrol @christarazi
Add deepcopy plugin
a2266f4 
It is needed to include FlowFilter in the generated CRD.

Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
@christarazi christarazi force-pushed the add-deepcopy-plugin branch from 8251746 to 983ed3f Compare July 21, 2023 20:54
@christarazi christarazi had a problem deploying to release-base-images July 21, 2023 20:54 — with GitHub Actions Failure
@christarazi christarazi added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. sig/hubble area/build Anything to do with the build, more general than area/CI labels Jul 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2023
@christarazi
Copy link
Member

/test

@AwesomePatrol
Update builder image
3da66ea 
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
@AwesomePatrol
Run deepcopy protoc plugin only for flow.proto
6878348 
Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
@AwesomePatrol AwesomePatrol temporarily deployed to release-base-images July 24, 2023 08:20 — with GitHub Actions Inactive
@sayboras
Copy link
Member

/test

@christarazi
Copy link
Member

Hit flake #27040

@aanm aanm requested review from gandro and removed request for kaworu July 25, 2023 07:40
gandro
gandro approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

sayboras
sayboras approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM ✅

bimmlerd
bimmlerd approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contrib LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 25, 2023
@youngnick
Copy link
Contributor

/test

@youngnick youngnick merged commit cc94abe into cilium:main Jul 26, 2023
@bimmlerd bimmlerd mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@christarazi christarazi christarazi approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/build Anything to do with the build, more general than area/CI area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AwesomePatrol @christarazi @sayboras @youngnick @gandro @bimmlerd