Skip to content

option: add LoadBalancerUsesDSR() helper #26898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

option: add LoadBalancerUsesDSR() helper #26898

merged 1 commit into from
Nov 16, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jul 18, 2023 •
edited
Loading

Spelling out the different modes that imply DSR is more robust than saying
"if it's not SNAT, it must be DSR".

As discussed in #25553 (review).

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@julianwiedmann julianwiedmann linked an issue Jul 18, 2023 that may be closed by this pull request
Consolidate checks for ad-hoc TUNNEL_PROTOCOL setting #25769
Closed
@julianwiedmann julianwiedmann added release-note/misc This PR makes changes that have no direct user impact. area/loadbalancing Impacts load-balancing and Kubernetes service implementations labels Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the 1.15-tunnel-dsr-cleanups branch 2 times, most recently from bcf9332 to 6c8a921 Compare July 20, 2023 13:38
@rgo3 rgo3 mentioned this pull request Aug 8, 2023
Merged
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 20, 2023
@julianwiedmann julianwiedmann force-pushed the 1.15-tunnel-dsr-cleanups branch from 6c8a921 to 5577ef6 Compare August 31, 2023 14:09
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann force-pushed the 1.15-tunnel-dsr-cleanups branch from 5577ef6 to b2f0825 Compare August 31, 2023 14:36
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 1, 2023
@julianwiedmann julianwiedmann force-pushed the 1.15-tunnel-dsr-cleanups branch from b2f0825 to 6292a93 Compare September 1, 2023 09:09
@julianwiedmann
Copy link
Member Author

/test

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 2, 2023
@github-actions
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Oct 16, 2023
@julianwiedmann
option: add LoadBalancerUsesDSR() helper
69a92ba 
Spelling out the different modes that imply DSR is more robust than saying
"if it's not SNAT, it must be DSR".

Suggested-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.15-tunnel-dsr-cleanups branch from 6292a93 to 69a92ba Compare November 14, 2023 09:40
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added kind/cleanup This includes no functional changes. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Nov 14, 2023
@julianwiedmann julianwiedmann changed the title 1.15 tunnel dsr cleanups config: add LoadBalancerUsesDSR() helper Nov 15, 2023
@julianwiedmann julianwiedmann changed the title config: add LoadBalancerUsesDSR() helper option: add LoadBalancerUsesDSR() helper Nov 15, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review November 15, 2023 15:43
@julianwiedmann julianwiedmann requested review from a team as code owners November 15, 2023 15:43
YutaroHayakawa
YutaroHayakawa approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

thorn3r
thorn3r approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code clarity++ 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2023
@julianwiedmann julianwiedmann merged commit 8d08a14 into cilium:main Nov 16, 2023
@julianwiedmann julianwiedmann deleted the 1.15-tunnel-dsr-cleanups branch November 16, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@ti-mo ti-mo ti-mo approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate checks for ad-hoc TUNNEL_PROTOCOL setting
5 participants
@julianwiedmann @squeed @ti-mo @YutaroHayakawa @thorn3r