Skip to content

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Jun 27, 2023

Following the introduction of IPv6 BPF masquerading, we can enable the related tests in datapath_configuration.go.

Logically, these tests should have been enabled when we added IPv6 BPF masquerading, but I missed them.

@qmonnet qmonnet added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. labels Jun 27, 2023
@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch 3 times, most recently from 892bc97 to 0191017 Compare June 27, 2023 14:01
@qmonnet
Copy link
Member Author

qmonnet commented Jun 27, 2023

/test

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 28, 2023
@qmonnet qmonnet added feature/ipv6 Relates to IPv6 protocol support feature/snat Relates to SNAT or Masquerading of traffic and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Jul 28, 2023
@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 28, 2023
@qmonnet qmonnet removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 29, 2023
@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 28, 2023
@qmonnet qmonnet removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Sep 28, 2023
@qmonnet qmonnet added the pinned These issues are not marked stale by our issue bot. label Oct 10, 2023
@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch from 0191017 to ecb6cbb Compare October 30, 2023 16:52
@cilium cilium deleted a comment from github-actions bot Oct 30, 2023
@cilium cilium deleted a comment from github-actions bot Oct 30, 2023
@cilium cilium deleted a comment from github-actions bot Oct 30, 2023
@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch from ecb6cbb to d7df97d Compare November 21, 2023 11:34
@qmonnet
Copy link
Member Author

qmonnet commented Nov 21, 2023

/test

@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch from d7df97d to 7a8b1ae Compare July 19, 2024 14:10
@qmonnet
Copy link
Member Author

qmonnet commented Jul 19, 2024

/test

@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch from 7a8b1ae to a5a6dde Compare July 22, 2024 16:36
@qmonnet
Copy link
Member Author

qmonnet commented Jul 22, 2024

/test

@qmonnet qmonnet requested a review from julianwiedmann July 22, 2024 16:57
@qmonnet qmonnet marked this pull request as ready for review July 22, 2024 16:57
@qmonnet qmonnet requested review from a team as code owners July 22, 2024 16:57
@qmonnet qmonnet requested a review from a team as a code owner July 22, 2024 16:57
@qmonnet
Copy link
Member Author

qmonnet commented Jul 22, 2024

Ginko failure's likely related 😞

image

@qmonnet qmonnet marked this pull request as draft July 22, 2024 19:54
@qmonnet
Copy link
Member Author

qmonnet commented Jul 24, 2024

Fails on bpf-next only, which is the only setup where we have the 3rd node without K8s, necessary condition to run the test.

Maybe worth trying to replicate without masquerading, to check whether simple IPv6 connects at all in this configuration (thanks Julian for the suggestion).

@qmonnet qmonnet removed the pinned These issues are not marked stale by our issue bot. label Feb 20, 2025
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 23, 2025
Copy link

github-actions bot commented Apr 6, 2025

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Apr 6, 2025
@qmonnet qmonnet reopened this Apr 7, 2025
Following the introduction of IPv6 BPF masquerading, we can enable the
related tests in datapath_configuration.go.

Signed-off-by: Quentin Monnet <qmo@qmon.net>
@qmonnet qmonnet force-pushed the pr/ipv6-masq-dpconf-tests branch from a5a6dde to 21e46cb Compare April 7, 2025 09:21
@qmonnet
Copy link
Member Author

qmonnet commented Apr 7, 2025

/test

@qmonnet
Copy link
Member Author

qmonnet commented Apr 7, 2025

Still not working. No cycles for looking into this, I'm closing the PR.

@qmonnet qmonnet closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/ipv6 Relates to IPv6 protocol support feature/snat Relates to SNAT or Masquerading of traffic release-note/ci This PR makes changes to the CI. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants