policy: Merge DerivedFromRules when merging map state entries #26346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep track of all contributing rule's labels in merged map state entries. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
|
/test |
aditighag
reviewed
Jun 27, 2023
There was a problem hiding this comment.
MergeReferences is in the hot path of policy computations logic.
Without this it is impossible to reliably test DerivedFromRules in unit tests
If this is only needed for unit tests, can we match DerivedFromRules in unit tests without relying on ordering? Also, I'm not seeing any Fixes tag, so is this change strictly required?
|
This pull request has been automatically marked as stale because it |
|
This pull request has not seen any activity since it was marked stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of all contributing rule's labels in merged map state entries. Without this it is impossible to reliably test DerivedFromRules in unit tests, as the value used for entries added by ToMapState depends on Go map iteration order which varies across runs.